Skip to content

Remove shaded deps #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

Remove shaded deps #1543

merged 2 commits into from
Sep 26, 2025

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Sep 7, 2025 •
edited
Loading

Description

I am not sure if this one is the best way to solve some issues related to native compilation. For Spring Native and Quarkus the grpc-netty-shaded is not recommended due to recents CVEs and a lot of GraalVM configurations and substitutions.

We strongly recommend NOT using a shaded Netty - the recent cves should tell you why

Not to mention that it increase drammatically the memory usage too: the most of the assumption from Netty related pooling is to be the only one (like last Highlander...)
if you shade it...it end up pretty bad.

I am not an expertise in the netty subject, I appreciate any suggestions and comments about this change.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mcruzdev mcruzdev requested review from a team as code owners September 7, 2025 17:09
siri-varma
siri-varma reviewed Sep 8, 2025
View reviewed changes
@mcruzdev mcruzdev mentioned this pull request Sep 24, 2025
Open
@salaboy
Copy link
Collaborator

salaboy commented Sep 25, 2025

@mcruzdev so this change in Quarkus works?

@salaboy
Copy link
Collaborator

salaboy commented Sep 25, 2025

@javier-aliaga @dapr/maintainers-java-sdk Can we approve and merge this, as this is blocking the quarkus integration.
Any objections?

salaboy
salaboy approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@javier-aliaga
Copy link
Contributor

So this is not a problem with CVEs but for native compilation, isnt it? I do not this PR introduces a lot of changes, so I am ok to merge it and give it a try.

@salaboy
Copy link
Collaborator

salaboy commented Sep 26, 2025 •
edited
Loading

@javier-aliaga This is for native compilation... let's merge it and see... if this cause any issues, we are not catching them with the pipelines.. so it is a good test.
But even with this, I don't think that spring native compilation will work.

@salaboy
Copy link
Collaborator

salaboy commented Sep 26, 2025

@siri-varma can you please approve this?

@salaboy salaboy merged commit f78c655 into dapr:master Sep 26, 2025
10 checks passed
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (d759c53) to head (58e4c7e).
⚠️ Report is 226 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1543      +/-   ##
============================================
+ Coverage     76.91%   78.49%   +1.58%     
- Complexity     1592     1913     +321     
============================================
  Files           145      215      +70     
  Lines          4843     5827     +984     
  Branches        562      649      +87     
============================================
+ Hits           3725     4574     +849     
- Misses          821      916      +95     
- Partials        297      337      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

salaboy pushed a commit that referenced this pull request Oct 13, 2025
@mcruzdev @salaboy
Replace grpc-netty-shaded to grpc-netty (#1543)
1263024 
Signed-off-by: Matheus Cruz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salaboy salaboy salaboy approved these changes

@javier-aliaga javier-aliaga javier-aliaga approved these changes

@siri-varma siri-varma Awaiting requested review from siri-varma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcruzdev @salaboy @javier-aliaga @siri-varma